Hello Erik,
I tried to post this to de dev mailing list, but got no response. So now I
am retrying by sending it directly to you.
Don't know; my xcircuit-dev admin list is full of spam, but nothing from
you. I'm CC'ing this to the email list, see if it gets there.
The following patch fixes five problems:
1: xtgui.c: GUI_init
X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 53 (X_CreatePixmap)
This is caused by the width and the heights not having proper values at the
right moment. Moved the XtGetValues of XtNHeight and XtNWidth up a few lines.
2: xtgui.c: main
Window initially not redrawn.
Caused by the value of suspend not being set.
Set the value just before the event loop starts. Is this the right place?
3: events.c: changepage
Segfaults when changepage to large value (should normally not happen)
Caused by memory not being allocated, but pageinst being set.
Fixed by allocating memory.
4: events.c, checkvalidname:
Not enough space is reserved when inserting "unref::", only space for one
additional character is allocated. (Probably just copy/pasted code from "_"
prefix).
5: netlist.c, search_on_siblings:
I do not know if this is a bug, but it seems to me that all points should
be transformed, not just the first one.
Not fixed in code, just added comment line.
Thanks for the fixes, and I'll take a look at the ones you're not sure
about.
By the way, if you're finding bugs in xtgui.c, then you should probably
try compiling the Tcl/Tk version of XCircuit. I like to keep the non-
Tcl/Tk version clean, and it helps to have people like you send me bug
reports (and fixes, even better!). But the Tcl/Tk version is more
complete, and the only one I use myself.
---Tim
+--------------------------------+-------------------------------------+
| Dr. R. Timothy Edwards (Tim) | email: [email protected] |
| Open Circuit Design, Inc. | web: http://opencircuitdesign.com |
| 22815 Timber Creek Lane | phone: (301) 528-5030 |
| Clarksburg, MD 20871-4001 | cell: (240) 401-0616 |
+--------------------------------+-------------------------------------+
_______________________________________________
Xcircuit-dev mailing list
[email protected]
http://www.opencircuitdesign.com/mailman/listinfo/xcircuit-dev
