[xcpu] Re: [PATCH 8 of 8] minor libspclient fix. in cases where spc_netmount failed, the same address was being freed twice

[Latchesar Ionkov]

You don't need to check if addr is NULL, free(NULL) is a nop. Otherwise,

Acked-by: Latchesar Ionkov <[EMAIL PROTECTED]>

On Nov 10, 2008, at 11:10 AM, Abhishek Kulkarni wrote:

1 file changed, 3 insertions(+), 1 deletion(-)
libspclient/netmount.c |    4 +++-


# HG changeset patch
# User Abhishek Kulkarni <[EMAIL PROTECTED]>
# Date 1226340464 25200
# Node ID 62fbf52fb96ddf4095f0e6be30c5fa07f72b673f
# Parent  2b4c0adacc655282c40f1ee3356dc00d68712b15

minor libspclient fix. in cases where spc_netmount failed, the same address was being freed twice.

Signed-off-by: Abhishek Kulkarni <[EMAIL PROTECTED]>

diff --git a/libspclient/netmount.c b/libspclient/netmount.c
--- a/libspclient/netmount.c
+++ b/libspclient/netmount.c
@@ -155,6 +155,7 @@
        }

        free(addr);
+       addr = NULL;
        fs = spc_mount(fd, NULL, user, auth, aux);
        if (!fs)
                goto error;
@@ -182,6 +183,7 @@
        return fs;

error:
-       free(addr);
+       if (addr)
+               free(addr);
        return NULL;
}