Acked-by: Latchesar Ionkov <[email protected]>
On Dec 16, 2008, at 9:28 PM, Abhishek Kulkarni wrote:
This patch fixes two minor bugs with bjs.
Interactive job submission didn't set the NODES environ variable
correctly. A check to ensure if the requested nodes are less than or
equal to the nodes in a pool was added back.
Signed-off-by: Abhishek Kulkarni <[email protected]>
Index: bjs.c
===================================================================
--- bjs.c (revision 751)
+++ bjs.c (working copy)
@@ -581,7 +581,7 @@
sexp_append_atom(sx, tmp);
for (l = j->nodes.next; l != &j->nodes; l = l->next) {
struct node_alloc_t *n = list_entry(l,struct
node_alloc_t,nodes_list);
- sprintf(tmp, "%d", bjs_node_idx[n->node]->node);
+ sprintf(tmp, "%s", bjs_node_idx[n->node]->node->name);
sexp_append_atom(sx, tmp);
}
client_send_sx(j->client, sx);
@@ -1149,13 +1149,11 @@
return -1;
}
} else {
- /* FIXME
if (nodes > p->nnodes) {
bjs_client_error(c, "The maximum number of nodes for pool"
" %s is %d.", p->name, p->nnodes);
return -1;
- }
- */
+ }
}
/*--- Check number of seconds requested ---*/