xdg-terminal has a couple issues in the generic (xterm) case. First,
the `which' command setting terminal_exec will always be empty because
stdout is being redirected to /dev/null. Second, the command is never
actually attempted to be executed.
Attached patch fixed this issue with xterm, at least for a simple
functional test. -e is needed for the argument passing case. This
works on xterm, but I don't know about other terminal emulators.
Perhaps xterm should just be hard-coded for the generic case.
--
Dan
Index: xdg-utils/scripts/xdg-terminal.in
===================================================================
RCS file: /cvs/portland/portland/xdg-utils/scripts/xdg-terminal.in,v
retrieving revision 1.3
diff -p -u -r1.3 xdg-terminal.in
--- xdg-utils/scripts/xdg-terminal.in 7 Dec 2006 19:30:43 -0000 1.3
+++ xdg-utils/scripts/xdg-terminal.in 12 Dec 2006 23:01:37 -0000
@@ -102,9 +102,15 @@ terminal_generic()
TERM=xterm
fi
- terminal_exec=`which $TERM >/dev/null 2>/dev/null`
+ terminal_exec=`which $TERM 2>/dev/null`
if [ -x "$terminal_exec" ]; then
+ if [ x"$1" == x"" ]; then
+ $terminal_exec
+ else
+ $terminal_exec -e "$1"
+ fi
+
if [ $? -eq 0 ]; then
exit_success
else
_______________________________________________
xdg mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/xdg
