A few other things that occurred to me about home.j and home-local.j:

- wouldn't it be better to have all the finder stuff (not just the 
findByPrimaryKey) within the scope of the existing <XDoclet:ifIsOfType 
type="javax.ejb.EntityBean"> tag?
- what if, when using CMP, the user wants to specify role permissions for 
findByPrimaryKey?  The only way to do this currently would be to add an 
@ejb:finder for it, but the home templates then end up adding the method 
twice...  perhaps the first inclusion needs something (ifDoesntHaveClassTag 
or ifClassTagValueNotEquals, maybe?) so that it doesn't add it if there's an 
@ejb:finder for findByPrimaryKey?
- there's still stuff in there to translate return type of Collection to 
java.util.Collection; the docs say "The return type in the signature must be 
fully qualified.", so is this still needed or should it be removed?
- less important, but if that translation is (or will be) useable, then why 
only for Collections?  Legacy code is more likely to be using Enumerations 
instead (and mine, since the generic finders in Toplink's base class return 
Enumerations :-( )


Andrew.

_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp


_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to