On Tue, 25 Sep 2001, Ara Abrahamian wrote:

> I thought more about it that I want to share with you. Templates files
> should not change at all. <Xdoclet: will still exist. The property file
> will look like this:
> forAllMethods.impl=xdoclet.ClassTags
> 
> So we will map <XDoclet:forAllMethods> to xdoclet.ClassTags and lookup
> the method there. We may also define something like Ant's taskdef:
> <XDoclet:tagDef tagName="forAllToplinkLinks"
> impl="mydoclet.ToplinkTags"/>

I'm not really convinced... what about a situation where we have
forAllPersistentFields, might be relevant to castor, ejb, toplink,
etc... probably not a perfect example, but hopefully enough to clarify my
query....  I like your initial idea of declaring different namespaces.

> Now the tricky part is the relationship between xdoclet.Tags-derived
> classes and TemplateEngine.
yes (o:

> We currently put all tag impls in
> SubTask-derived classes which is itself derived from TemplateEngine and
> use methods of it (getCurrentMethod(), generate(), etc). We'll have
> xdoclet.Tags
This is an abstract class/interface that tag providers implement?

> which I think shouldn't derive from TemplateEngine because:
> previously we had a one subtask-one template situation. But in Tags case
> we have n xdoclet.Tags-one template-one subtask. SubTask only is where
> Ant settable config params are set. So to keep track of
> currentMethod/currrentClass and things like that TemplateEngine should
> be a single instance shared by all Tags. So I think we should make it
> singleton and instead of doing getCurrentClass() as before in SubTask,
> do a TemplateEngine.getInstance().getCurrentClass() (we can indeed make
> it easier by defining a getCurrentClass() in xdoclet.Tags that delegates
> to TemplateEngine's single instance, this will also make refactoring
> easier).
yep

> Any ideas? I want to make sure I haven't missed anything critical before
> investing time on it. To me it seems smoother than I've thought.
only the comment on namespaces.

cheers
dim



_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to