Great job Vincent! The code is of very good quality. TemplateParser in particular caught my eyes, the cleanness of your code shows that Dmitri did a very good job of refactoring the TemplateEngine while he was working on new tag handling mechanism. Fabulous!
Just some more points: - Why don't you traverse the whole hierarchy? Why stop in superclass and not superclass of superclass and so on? It's quite possible to have a deeper hierarchy. - Another check which is missing is Ant <property/> checks. As you know it's for some time that xdoclet also supports setting @tag parameter values via Ant properties. I'm wondering how we can also check this one! If done correctly I think xdoclet's regeneration mechanism will be complete. Maybe a good solution is to check build.xml's timestamp and assume a property change when the file is modified? I don't know whether there's a way to find out the current build.xml file via Ant's API or not. But that's even more complicated, because user can specify properties in a separate property file. A through look at Ant's API will show us whether it's possible or not. Enjoy the holidays ;-) Ara. > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:xdoclet-devel- > [EMAIL PROTECTED]] On Behalf Of Vincent Harcq > Sent: Thursday, December 27, 2001 8:21 PM > To: [EMAIL PROTECTED] > Subject: [Xdoclet-devel] CVS update: 'xdoclet/core/src/xdoclet > DocletContext.java DocletTask.java TemplateSubTask.java' > > Update of /cvsroot/xdoclet/xdoclet/core/src/xdoclet > In directory usw-pr-cvs1:/tmp/cvs-serv4570/xdoclet > > Modified Files: > DocletContext.java DocletTask.java TemplateSubTask.java > Log Message: > - Add a "force" attribute to doclet to force the regeneration of all > files refardless of timestamps. > - Timestamp checking now looks for timestamp on current and all parent > classes as well as merge files that are not part of xdoclet JAR. > - mergedir attribute could not be overwritten at a subtask level > > _______________________________________________ > Xdoclet-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
