Howdy Vincent,

I was also working on the same problem, and just noticed you checked it
in.

I am curious.  HomeTagsHandler::jndiName will "create" a LocalJNDI name
if it isn't already set.

So making the template check for existance of the class tag isn't quite
enough.

What I was going to change it to was:
<XDtEjb:ifRemoteEjb>
   <jndi-name><XDtEjbHome:jndiName type="remote"/></jndi-name>
</XDtEjb:ifRemoteEjb>
<XDtEjb:ifLocalEjb>
   <local-jndi-name><XDtEjbHome:jndiName type="local"/></local-jndi-name>
</XDtEjb:ifLocalEjb>

But before doing that, I realized that the jndiName function makes some
bad assumptions as to how to "guess" the jndi names.

One being that, depending on the ejb:bean view-type parameter, the
generated JNDI name changes
ie:
Given EJB named "Account"

view-type="remote":
jndiName = "Account"

view-type="local":
jndiName = "Account"

view-type="both":
jndiName = "Account"
localJndiName = "AccountLocal"


I believe that this is wrong, since if you change the view type from
local to "both", you end up with your jndi name getting changed (thus
breaking any code that calls a "local" only method (ie. CMR))

What I think it should be, is:
jndi-local-name || compName(clazz,"local")
and
jndi-name || compName(clazz,"remote")

This keeps the JNDI names from magically changing on you when you change
the view-type of an ejb.


I've already made these changes, and they do work (at least for jboss
they work).

I just wanted to avoid stepping on toes here, as well as make sure I'm
not completly on crack as to my view of how it should work.

Thanks,

-David

p.s. If this didn't make any sense, tell me, and I'll try to explain my
point better after some sleep.

On Tue, 15 Jan 2002, Vincent Harcq wrote:

> Update of /cvsroot/xdoclet/xdoclet/core/resources/xdoclet/ejb/vendor
> In directory usw-pr-cvs1:/tmp/cvs-serv1453
> 
> Modified Files:
>       jboss_xml.j 
> Log Message:
> [JBoss] Add local-jndi-name for session/entity bean DD
> 
> _______________________________________________
> Xdoclet-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to