Howdy yall, Well, in my effort to get class tag merging (ie: @ejb:bean in base, and @ejb:bean in concrete ejb to merge), I've done some of the conversion to XDocletTagSupport.
My only concern is that it seems to me that a lot of the code in xdoclet is copy any paste. Meaning many, many places try to lookup a tag+param using DocletUtil but first checking for it in currentTag(), and then walking the tree backwards looking for the tag. I've removed all the instances I came across and replaced them with the simpler XDocletTagSupport::getClassTagValue type lookup (thus removing 50+ lines of code in each place). My concern is, am I being over-zealous in my removal of code? Or is it indeed true that a lot of the code is copy and paste? It's hard to tell since the beautifier makes all the code look like one person wrote it. So there's no tell-tale signs (ie: bad formatting) of a copy/paste. I just don't want to screw anything up. And since we are lacking a testsuite, all I can do to ensure my changes aren't screwing stuff up, is build the example apps, and build/deploy my own companies project. Is it safe to assume that someone will yell at me if I totally screw something up? Are the other developers of xdoclet actively using the CVS version for day-to-day projects (which would imply that you'd notice if I messed something up). Thanks, -David _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
