Currently, entity-body.j has the following in ejbStore:
    <XDtMethod:ifHasMethod name="ejbStore">
     <XDtMethod:ifIsNotAbstract>
      <XDtEjbCmp:ifNotUsingCmp2>
      if (isModified())
      {
      </XDtEjbCmp:ifNotUsingCmp2>
         super.ejbStore();
      <XDtEjbCmp:ifNotUsingCmp2>
      }
      </XDtEjbCmp:ifNotUsingCmp2>

     </XDtMethod:ifIsNotAbstract>
    </XDtMethod:ifHasMethod>

Since I wanted the generated ejbStore to call a DAO's store method whether 
or not the superclass had this method, I had to put the call after this.  
However, that means it's still being called for my BMP beans even if 
isModified() returns false!

Why should the isModified() check only be done if there's a non-abstract 
ejbStore in an ancestor?  Isn't it only the super.ejbStore() call that needs 
to check for this?  In which case, wouldn't it be better to have
      <XDtEjbCmp:ifNotUsingCmp2>
      if (isModified())
      {
      </XDtEjbCmp:ifNotUsingCmp2>
    <XDtMethod:ifHasMethod name="ejbStore">
     <XDtMethod:ifIsNotAbstract>
         super.ejbStore();
     </XDtMethod:ifIsNotAbstract>
    </XDtMethod:ifHasMethod>
      <XDtEjbCmp:ifNotUsingCmp2>
     <XDtEjbDao:ifUsingDao>
      getDao().store(this);
     </XDtEjbDao:ifUsingDao>
      }
      </XDtEjbCmp:ifNotUsingCmp2>

(also allowing me to make the DAO call only when the EJB has been modified)?


Andrew.

_________________________________________________________________
Join the world�s largest e-mail service with MSN Hotmail. 
http://www.hotmail.com


_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to