I agree on the branching : it should be possible to merge main and branch at the end of the refactoring no ? I am pretty sure we need a Tag WITH a Branch, I think you only created a Branch. But maybe the changes will be too deep for merge to work. Aslak can you talk a bit more about the kind of changes and why merging could not be possible ?
For unit tests I think there is nothing to stop us add more during the refactoring. Creating a test case that breaks all the bug report is already a good step, Solving them can be done after xjavadoc is there more easily. There is a lot of work here that can be done before any changes to xdoclet core so maybe this is the best solution to not interfere with Aslak work. Then merging can be forgotten. For debugging Value Object, I really need to use them in deployed bean to see what the problems are. I wanted to let that for later when unit testing is done. It is an add-on feature so it can wait. Bugs are more important imho. Vincent > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]] On Behalf > Of Andrew Stevens > Sent: mercredi 13 mars 2002 23:46 > To: [EMAIL PROTECTED] > Subject: Re: [Xdoclet-devel] XJAVADOC_REFACTORING branch in > xdoclet module > > > A wise old hermit known only as Aslak Hellesy > <[EMAIL PROTECTED]> once > said: > > > After a discussion with Ara yesterday, we decided that it's time to > > start replacing com.sun.javadoc with xjavadoc in the > xdoclet source. I > > have created a new branch named XJAVADOC_REFACTORING for this. > > > > PLEASE TRY TO AVOID ADDING/COMMITTING ANYTHING TO THE XDOCLET CORE > > UNTIL THE REFACTORING IS DONE. > > > > It's a very big job, so I would like to warn you all that this might > > take some time > ... > > In which case, might it not be better to first concentrate on > sorting out > bugs (and the valueobjects) and adding more unit tests for a > 1.1.3 release > (say, around the end of the month), and do the xjavadoc > integration once > it's as robust as we can make it? There's almost 50 open > tracker items at > the moment, plus a couple of messages in xdoclet-user > complaining that > 1.1.2 broke things that worked previously... > > Of course, since there's the new branch it doesn't > necessarily hold up the > refactoring work, but if we've got to hold off on stuff in > the main branch > till that's done then what's the point of the branch? It > might as well go > straight into the main code. > > > The first > > step is to get things to compile, the second is to verify that > > everything works as before. > > > > It's important that as many as possible can participate in > the second > > step, as nobody knows all parts an dark corners of xdoclet > anymore. The > > refactoring will most likely introduce some bugs, so let's > kill them > > together. > > Unit tests, and plenty of them :-) > Let's get a comprehensive suite of tests done first, and > there'll be less > work needed to find the bugs later. > > > Andrew. > > _______________________________________________ > Xdoclet-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
