User: vharcq
Date: 02/04/03 03:09:37
Modified: src/xjavadoc XDoc.java
Log:
It's getter better all the time (better, better, be-tter) : cumulative perf
improvement : 24%
(again thanks to Aslak/Ara of course ;-) )
Revision Changes Path
1.21 +22 -13 xjavadoc/src/xjavadoc/XDoc.java
Index: XDoc.java
===================================================================
RCS file: /cvsroot/xdoclet/xjavadoc/src/xjavadoc/XDoc.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -w -r1.20 -r1.21
--- XDoc.java 3 Apr 2002 10:56:51 -0000 1.20
+++ XDoc.java 3 Apr 2002 11:09:37 -0000 1.21
@@ -483,23 +483,14 @@
*/
public XTag[] tags(String tagName) {
parse();
+ // TODO ASLAK ??? ArrayList tags =
(ArrayList)_tagMap.get(dotted(tagName));
ArrayList tags = (ArrayList)_tagMap.get(tagName);
if (tags == null) {
- String dottedFormatTagName = tagName.replace(':', '.');
- tags = (ArrayList)_tagMap.get(dottedFormatTagName);
- }
- if (tags == null) {
- String colonedFormatTagName = tagName.replace('.', ':');
- tags = (ArrayList)_tagMap.get(colonedFormatTagName);
- }
-
- if (tags == null) {
return new XTag[0];
}
else {
- XTag[] tagArray = new XTag[tags.size()];
- return (XTag[])tags.toArray(tagArray);
+ return (XTag[])tags.toArray(new XTag[tags.size()]);
}
}
@@ -573,10 +564,12 @@
* @todo-javadoc Describe the method parameter
*/
private XTag addTag_Impl(String tagName, String text) {
- ArrayList tags = (ArrayList)_tagMap.get(tagName);
+ // TODO ASLAK ??? String dottedTagName = dotted(tagName);
+ String dottedTagName = tagName;
+ ArrayList tags = (ArrayList)_tagMap.get(dottedTagName);
if (tags == null) {
tags = new ArrayList();
- _tagMap.put(tagName, tags);
+ _tagMap.put(dottedTagName, tags);
}
XTag tag = XTagFactory.getInstance().createTag(tagName, text);
tags.add(tag);
@@ -684,7 +677,23 @@
_dirty = false;
}
+
// private final static boolean isTabOrSpace(String s) {
// return (s.charAt(0) == ' ') || (s.charAt(0) == '\t');
// }
+
+ /**
+ * Describe what the method does
+ *
+ * @todo is this really needed ?
+ * @param tagName Describe what the parameter does
+ * @return Describe the return value
+ * @todo-javadoc Write javadocs for method
+ * @todo-javadoc Write javadocs for method parameter
+ * @todo-javadoc Write javadocs for return value
+ */
+ private String dotted(String tagName) {
+ return tagName.replace(':', '.');
+ }
+
}
_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
