The following comment has been added to this issue:

     Author: Stephen Cuppett
    Created: Sat, 10 Jan 2004 4:58 PM
       Body:
I can see how a "depends" attribute can be added to jbossservice and in there you can 
put in the datasource; however, this really is only a temporary fix and doesn't 
address the real issue.  Multiple depends may need to be added and the merge file 
contents should be placed inside of the mbean in addition to the datasource being 
added as a dependency automatically by the task.
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/xdoclet/secure/ViewIssue.jspa?key=XDT-767


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XDT-767
    Summary: JBossService could correctly depend on datasource.
       Type: Improvement

     Status: Open
   Priority: Major

 Original Estimate: 1 hour
 Time Spent: Unknown
  Remaining: 1 hour

    Project: XDoclet
 Components: 
             Hibernate Module
   Versions:
             1.2

   Assignee: xdoclet-devel (Use for new issues)
   Reporter: Stephen Cuppett

    Created: Sat, 10 Jan 2004 4:19 PM
    Updated: Sat, 10 Jan 2004 4:58 PM
Environment: Ant 1.5.4 with XDoclet 1.2 and JBoss 3.2.2

Description:
>From the Hibernate documentation and using with JBoss, the MBean descriptor created 
>for JBoss should look something like the following:

<server>
<mbean code="net.sf.hibernate.jmx.HibernateService" 
name="jboss.jca:service=HibernateFactory,
                            name=HibernateFactory">
    <depends>jboss.jca:service=RARDeployer</depends>
    <depends>jboss.jca:service=LocalTxCM,name=MySqlDS</depends>
    <!-- Make it deploy ONLY after DataSource had been started -->
    <attribute name="MapResources">mappings/Attribute.hbm.xml</attribute>
    <attribute name="JndiName">java:/hibernate/HibernateFactory</attribute>
    <attribute name="Datasource">java:/MySqlDS</attribute>
    <attribute name="Dialect">net.sf.hibernate.dialect.MySQLDialect</attribute>
    <attribute 
name="TransactionStrategy">net.sf.hibernate.transaction.JTATransactionFactory</attribute>
    <attribute 
name="TransactionManagerLookupStrategy">net.sf.hibernate.transaction.JBossTransactionManagerLookup</attribute>
    <attribute name="UseOuterJoin">false</attribute>
    <attribute name="ShowSql">false</attribute>
    <attribute name="UserTransactionName">UserTransaction</attribute>
</mbean>
</server>


However, presently, the currently generated MBean descriptor by jbossservice inside 
hibernatedoclet looks like the following:

<server>
<mbean code="net.sf.hibernate.jmx.HibernateService" 
name="jboss.jca:service=HibernateFactory,
                            name=HibernateFactory">
    <depends>jboss.jca:service=RARDeployer</depends>
    <attribute name="MapResources">mappings/Attribute.hbm.xml</attribute>
    <attribute name="JndiName">java:/hibernate/HibernateFactory</attribute>
    <attribute name="Datasource">java:/MySqlDS</attribute>
    <attribute name="Dialect">net.sf.hibernate.dialect.MySQLDialect</attribute>
    <attribute 
name="TransactionStrategy">net.sf.hibernate.transaction.JTATransactionFactory</attribute>
    <attribute 
name="TransactionManagerLookupStrategy">net.sf.hibernate.transaction.JBossTransactionManagerLookup</attribute>
    <attribute name="UseOuterJoin">false</attribute>
    <attribute name="ShowSql">false</attribute>
    <attribute name="UserTransactionName">UserTransaction</attribute>
</mbean>
</server>


The second <depends> tag is not added to ensure that the datasource is ready before 
loading Hibernate.  This can be overcome by including the second line in 
jboss-service-custom.xdt and that is why I did not mark this as a bug, but as an 
improvement; however, I feel that as it stands now there is a redundancy of places 
that need changed whenever a datasource is updated which is what XDoclet and Ant aim 
to reduce.

The documentation for what should be included in the XML generated MBean descriptor is 
at:

http://www.hibernate.org/66.html



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/xdoclet/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
_______________________________________________
xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to