I've applied Clifton's patch to fix this bug - let me know if it works as desired.
Matt > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf > Of Rupp, Heiko > Sent: Friday, July 09, 2004 1:18 AM > To: [EMAIL PROTECTED] > Subject: RE: [Xdoclet-devel] Bug fix for XJavaDoc - what > happend to XJD-43? > > > Clifton, > > I can't say anything on Xdoclet2, but I am willing to help > you (*) on xdoclet1, if you want commit access. > > Heiko > > (*) limited time permitting > > >-----Original Message----- > >From: [EMAIL PROTECTED] > >[mailto:[EMAIL PROTECTED] On Behalf > >Of Clifton C. Craig > >Sent: Thursday, July 08, 2004 7:58 PM > >To: [EMAIL PROTECTED] > >Subject: Re: [Xdoclet-devel] Bug fix for XJavaDoc - what > >happend to XJD-43? > > > >Yes, I would love commit access but I'm afraid I wouldn't know > >what to do with it. Before I get in too deep I think I'd need > >a course on how this stuff works. I'd love to contribute I'm > >just afraid that there's too much involved. The last couple of > >times I tried to build XDoclet from a CVS checkout I got > >stumped. I recently got hung up on the > >XDoclet2 project trying to just checkout and build the dang > >thing. I'll tell you what. I'll shut my mouth for the time > >being, read up on Maven (which appears to be your build tool > >of choice) and try to figure out how to at least do checkouts > >and builds through CVS. If you or anyone can help me along the > >way I'd appreciate it. But let me 1st try to get my feet wet > >with that 1st step. > > > >Clifton C. Craig, Software Engineer > >Intelligent Computer Systems - A Division of GBG > >2101 Embassy Drive > >Lancaster, PA 17603 > > > >Phone: 717-295-7977 ext. 621 > >Fax: 717-295-7683 > >[EMAIL PROTECTED] > >[EMAIL PROTECTED] > > > > > > > >Mathias Bogaert wrote: > > > >> Clifton, > >> > >> XDoclet developers are very busy with other project. Would you like > >> CVS commit access? > >> > >> Mathias Bogaert > >> > >> On 07 Jul 2004, at 22:37, Clifton C. Craig wrote: > >> > >>> I submitted an Issue to Jira back in March regarding a bug in the > >>> XJavadoc engine. (See below.) I did this after repeatedly > >submitting > >>> the problem and the fix to the mailing list. There (in > >JIRA) I posted > >>> the code to fix the bug. The fix was very simple.I also posted a > >>> reminder to the developer list after hearing talk of the > >next release > >>> of XDoclet and noticing the issue was still unresolved in > >JIRA. I was > >>> sure it would make it into the next release but it somehow didn't > >>> make the cut. What did I do wrong? I was really hoping that > >the issue > >>> would be fixed so that I don't have to hack the Jar the way > >that I've > >>> been doing. If I knew how I would upload the fix directly to the > >>> repository myself. What can I do to get this issue resolved? > >>> > >>> Clifton C. Craig, Software Engineer > >>> Intelligent Computer Systems - A Division of GBG > >>> 2101 Embassy Drive > >>> Lancaster, PA 17603 > >>> > >>> Phone: 717-295-7977 ext. 621 > >>> Fax: 717-295-7683 > >>> [EMAIL PROTECTED] > >>> [EMAIL PROTECTED] > >>> > >>> > >>> > >>> Clifton C. Craig wrote: > >>> > >>>> Andrew, > >>>> > >>>> I opened an issue in JIRA. I'm not sure exactly how to go about > >>>> uploading a patch. I know little about CVS and open-source > >>>> practices. I did, however, copy my patch as a comment in JIRA. I > >>>> patch is extremely simple and minor (literally 3 lines of > >code) and > >>>> would probably be nothing to an experienced developer to > >>>> incorporate. I do not mind doing the patch myself > though. I'd just > >>>> need someone to walk me through it. It would be a great start at > >>>> learning this stuff. > >>>> > >>>> Clifton C. Craig, Software Engineer > >>>> Intelligent Computer Systems - A Division of GBG > >>>> 2101 Embassy Drive > >>>> Lancaster, PA 17603 > >>>> > >>>> Phone: 717-295-7977 ext. 621 > >>>> Fax: 717-295-7683 > >>>> [EMAIL PROTECTED] > >>>> [EMAIL PROTECTED] > >>>> > >>>> > >>>> Andrew Stevens wrote: > >>>> > >>>>> On Fri, 2004-03-26 at 20:53, Clifton C. Craig wrote: > >>>>> > >>>>>> I'm still waiting for advice on this topic. Any takers? > >>>>>> > >>>>> > >>>>> > >>>>> Strange, I don't think I saw your original message. Oh > >well. Can > >>>>> you open an issue in JIRA > >>>>> (http://opensource.atlassian.com/projects/xdoclet/) and > >upload the > >>>>> fix there? That way things don't get missed. Thanks. > >>>>> > >>>>> > >>>>> Andrew. > >>>>> > >>>>> > >>>>>> Clifton C. Craig, Software Engineer Intelligent Computer > >Systems - > >>>>>> A Division of GBG > >>>>>> 2101 Embassy Drive > >>>>>> Lancaster, PA 17603 > >>>>>> > >>>>>> Phone: 717-295-7977 ext. 621 > >>>>>> Fax: 717-295-7683 > >>>>>> [EMAIL PROTECTED] > >>>>>> [EMAIL PROTECTED] > >>>>>> > >>>>>> > >>>>>> Clifton C. Craig wrote: > >>>>>> > >>>>>> > >>>>>>> Hello, > >>>>>>> > >>>>>>> I'm a newcomer and I have a simple bug fix for > >XJavaDoc. I found > >>>>>>> that saving source files to another folder would cause > >truncation > >>>>>>> of the source. What I noticed was the FileWriter in the save > >>>>>>> method of xjavadoc.SourceClass was not being flushed like the > >>>>>>> Writer returned from the _sourceFile member when a root > >directory > >>>>>>> is not given. My modifications are only to the save method and > >>>>>>> include two lines of code. The source to the revised > >save method > >>>>>>> is as follows: > >>>>>>> > >>>>>>> /** > >>>>>>> * Saves the class at root dir rootDir. The actual > >java file is > >>>>>>> derived from > >>>>>>> * tha package name. If no root dir is specified, > >save where it > >>>>>>> was loaded from > >>>>>>> * > >>>>>>> * @param rootDir the root directory. > >>>>>>> * @return the relative fileName to > >which the file > >>>>>>> was saved. > >>>>>>> * @throws IOException if the file couldn't be saved > >>>>>>> */ > >>>>>>> public String save( File rootDir ) throws IOException > >>>>>>> { > >>>>>>> if( !isWriteable() ) > >>>>>>> { > >>>>>>> throw new UnsupportedOperationException( "Can't save > >>>>>>> classes that aren't parsed in AST mode (do > >>>>>>> getXJavaDoc().setUseNodeParser(true) before parsing > starts!)" ); > >>>>>>> } > >>>>>>> if( getContainingClass() != null ) > >>>>>>> { > >>>>>>> // inner class. can't save these. > >>>>>>> throw new UnsupportedOperationException( > "Can't save > >>>>>>> inner classes" ); > >>>>>>> } > >>>>>>> else if( rootDir != null ) > >>>>>>> { > >>>>>>> String fileName = getFileName( getQualifiedName() ); > >>>>>>> File javaFile = new File( rootDir, fileName ); > >>>>>>> > >>>>>>> javaFile.getParentFile().mkdirs(); > >>>>>>> FileWriter fwtr = new FileWriter( javaFile ); > >>>>>>> print( fwtr ); > >>>>>>> fwtr.flush(); > >>>>>>> fwtr.close(); > >>>>>>> return fileName; > >>>>>>> } > >>>>>>> else > >>>>>>> { > >>>>>>> // no root dir specified, save in place > >>>>>>> Writer outputStream = _sourceFile.getWriter(); > >>>>>>> > >>>>>>> print( new PrintWriter( outputStream ) ); > >>>>>>> outputStream.flush(); > >>>>>>> outputStream.close(); > >>>>>>> return _sourceFile.toString(); > >>>>>>> } > >>>>>>> } > >>>>>>> > >>>>>>> I'm not sure about how things get committed in open source > >>>>>>> projects but I do know that this is a bug. I also > know that my > >>>>>>> patch, while small, does correct the problem. I'm not > >sure about > >>>>>>> where to go from here, so if someone wants to advise me I'd be > >>>>>>> most thankful. > >>>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> > >>>>> ------------------------------------------------------- > >>>>> This SF.Net email is sponsored by: IBM Linux Tutorials > Free Linux > >>>>> tutorial presented by Daniel Robbins, President and CEO > of GenToo > >>>>> technologies. Learn everything from fundamentals to system > >>>>> > >administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=cli > >>>>> ck _______________________________________________ > >>>>> xdoclet-devel mailing list [EMAIL PROTECTED] > >>>>> https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > >>>>> > >>>>> > >>>>> > >>>> > >>>> > >>>> ------------------------------------------------------- > >>>> This SF.Net email is sponsored by: IBM Linux Tutorials > Free Linux > >>>> tutorial presented by Daniel Robbins, President and CEO > of GenToo > >>>> technologies. Learn everything from fundamentals to system > >>>> > >administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=clic > >>>> k _______________________________________________ > >>>> xdoclet-devel mailing list > >>>> [EMAIL PROTECTED] > >>>> https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > >>>> > >>>> > >>> > >>> > >>> ------------------------------------------------------- > >>> This SF.Net email sponsored by Black Hat Briefings & Training. > >>> Attend Black Hat Briefings & Training, Las Vegas July 24-29 > >- digital > >>> self defense, top technical experts, no vendor pitches, unmatched > >>> networking opportunities. Visit www.blackhat.com > >>> _______________________________________________ > >>> xdoclet-devel mailing list > >>> [EMAIL PROTECTED] > >>> https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > >>> > >> > >> > >> > >> ------------------------------------------------------- > >> This SF.Net email sponsored by Black Hat Briefings & Training. > >> Attend Black Hat Briefings & Training, Las Vegas July 24-29 > >- digital > >> self defense, top technical experts, no vendor pitches, unmatched > >> networking opportunities. Visit www.blackhat.com > >> _______________________________________________ > >> xdoclet-devel mailing list > >> [EMAIL PROTECTED] > >> https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > >> > >> > > > > > >------------------------------------------------------- > >This SF.Net email sponsored by Black Hat Briefings & Training. > >Attend Black Hat Briefings & Training, Las Vegas July 24-29 - > >digital self defense, top technical experts, no vendor > >pitches, unmatched networking opportunities. Visit > >www.blackhat.com _______________________________________________ > >xdoclet-devel mailing list > >[EMAIL PROTECTED] > >https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > > > > > > > ------------------------------------------------------- > This SF.Net email sponsored by Black Hat Briefings & Training. > Attend Black Hat Briefings & Training, Las Vegas July 24-29 - > digital self defense, top technical experts, no vendor pitches, > unmatched networking opportunities. Visit www.blackhat.com > _______________________________________________ > xdoclet-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com _______________________________________________ xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
