The following comment has been added to this issue:

     Author: Vassil Dichev
    Created: Mon, 13 Sep 2004 4:48 PM
       Body:
OK, I can see what threw us off.

In a word, ifHasConfigParam does not have the expected behavior:
1. If there's a default value for a parameter (say, Boolean.FALSE in the case of 
showSql) and ifHasConfigParam is used, the default value appears in the generated xml 
even when the parameter is not specified!
Expected: The attribute should not appear if it's not specified in the template. Isn't 
that what ifHasConfigParam is for?!
2. If there's no default value for a parameter (it's null), and ifHasConfigParam is 
not used, an empty string appears as the value of the attribute even when the 
parameter is not specified in the template.
Expected: The attribute should not appear at all. Why try to print a value if it has 
no default? An empty value doesn't make sense.

So, when the parameter is not in the template, it works properly only when 
ifHasConfigParam is specified *AND* there's no default value (should be *OR*, 
shouldn't it?). It seems that the default value of the parameter defeats the purpose 
of ifHasConfigParam and when a non-null parameter is obtained, there's no way to tell 
if it comes from the default value or from the template.

This seems more tricky to fix, but if it worked as described, there wouldn't be any 
need to change primitive types to objects now and David Lloyd's fix would have worked 
as he expected.

Am I getting too deep into details? :)
---------------------------------------------------------------------
View this comment:
  
http://opensource.atlassian.com/projects/xdoclet/browse/XDT-1059?page=comments#action_14834

---------------------------------------------------------------------
View the issue:
  http://opensource.atlassian.com/projects/xdoclet/browse/XDT-1059

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XDT-1059
    Summary: jbossservice UseOuterJoin not supported anymore in hibernate 2.1.6
       Type: Bug

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: XDoclet
 Components: 
             Hibernate Module
   Versions:
             1.2.1
             1.2.2

   Assignee: xdoclet-devel (Use for new issues)
   Reporter: Thomas Herbst

    Created: Tue, 7 Sep 2004 3:15 PM
    Updated: Mon, 13 Sep 2004 4:48 PM

Description:
With hibernate 2.1.6 the UseOuterJoin is removed from the 
net.sf.hibernate.jmx.HibernateService MBean so the attribute can not be set default to 
false, because jboss cannot deploy the service anymore.


21:31:02,500 INFO  [NamingService] Started jnpPort=1099, rmiPort=1098, backlog=5
0, bindAddress=/0.0.0.0, Client SocketFactory=null, Server SocketFactory=org.jbo
[EMAIL PROTECTED]
21:31:03,721 INFO  [ServiceConfigurator] Problem configuring service jboss.jca:s
ervice=HibernateServices
org.jboss.deployment.DeploymentException: No Attribute found with name: UseOuter
Join
        at org.jboss.system.ServiceConfigurator.configure(ServiceConfigurator.ja
va:321)
        at org.jboss.system.ServiceConfigurator.internalInstall(ServiceConfigura
tor.java:160)
        at org.jboss.system.ServiceConfigurator.install(ServiceConfigurator.java
:114)
        at org.jboss.system.ServiceController.install(ServiceController.java:198
)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/xdoclet/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
_______________________________________________
xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to