The following issue has been updated:

    Updater: Mark Candle (mailto:[EMAIL PROTECTED])
       Date: Mon, 18 Apr 2005 10:50 AM
    Changes:
             Attachment changed to MODplugin.jelly
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://opensource.atlassian.com/projects/xdoclet/browse/XDT-1346?page=history

---------------------------------------------------------------------
View the issue:
  http://opensource.atlassian.com/projects/xdoclet/browse/XDT-1346

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XDT-1346
    Summary: Add support for includes and excludes in fileset declaration
       Type: New Feature

     Status: Open
   Priority: Minor

 Original Estimate: 20 minutes
 Time Spent: Unknown
  Remaining: 20 minutes

    Project: XDoclet
 Components: 
             Maven Plugin
   Versions:
             1.2

   Assignee: xdoclet-devel (Use for new issues)
   Reporter: Mark Candle

    Created: Mon, 18 Apr 2005 10:48 AM
    Updated: Mon, 18 Apr 2005 10:50 AM

Description:
Hi,

I was enable to use the "includes" and "excludes" attributes to the FileSet 
declaration in the project.properties. This means that I could not include a 
series of comma seperated file patterns in the same fileset.

I was trying to do something like this:

maven.xdoclet.webdoclet.fileset.0.include=**/html/*Tag.java
maven.xdoclet.webdoclet.fileset.0.include=**/dyn/*Tag.java
maven.xdoclet.webdoclet.fileset.0.exclude=**/deprecated/*Tag.java
maven.xdoclet.webdoclet.fileset.0.exclude=**/hit/*Tag.java

But this kept giving me unexpected results, so I tried this:

maven.xdoclet.webdoclet.fileset.0.include=**/html/*Tag.java
maven.xdoclet.webdoclet.fileset.1.include=**/dyn/*Tag.java
maven.xdoclet.webdoclet.fileset.0.exclude=**/deprecated/*Tag.java
maven.xdoclet.webdoclet.fileset.1.exclude=**/hit/*Tag.java

But then for complicated file lists, this becomes cumbersome. 

Also it didn't work with maven.xdoclet.webdoclet.jsptaglib since it you can 
only specify one fileset from which to generate a TLD from i.e. :

- "maven.xdoclet.webdoclet.fileset.0.include" will select files for the taglib 
defined in "maven.xdoclet.webdoclet.jsptaglib.0".
- But files declared in say "maven.xdoclet.webdoclet.fileset.1" won't be 
included in "maven.xdoclet.webdoclet.jsptablib.0").

In any case, the plugin.jelly limits the number of filesets to 10. 

What would be nice is a cleaner notation like this instead:

maven.xdoclet.webdoclet.fileset.0.includes=**/html/*Tag.java,=**/dyn/*Tag.java
maven.xdoclet.webdoclet.fileset.0.excludes=**/deprecated/*Tag.java,=**/hit/*Tag.java

This works fine and included below is the diff of the original plugin.jelly 
with the one I modified. I did the modification for all the fileset 
declarations, not just jsptaglib. 




60,65c60
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.jmxdoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.jmxdoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
1024,1029c1019
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.mockobjectdoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.mockobjectdoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
1740,1745c1730
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.xdoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.xdoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
2398,2403c2383
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.jdodoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.jdodoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
2925,2930c2905
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.portletdoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.portletdoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
3477,3483c3452
< 
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.webdoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.webdoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
5461,5466c5430
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.documentdoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.documentdoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
7445,7450c7409
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.ejbdoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.ejbdoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">
10469,10474c10428
<                     <j:set var="fileset_index_includes_var_name" 
value="maven.xdoclet.hibernatedoclet.fileset.${fileset_index}.includes"/>
<                                       <j:set 
var="fileset_index_excludes_var_name" 
value="maven.xdoclet.hibernatedoclet.fileset.${fileset_index}.excludes"/>
<                     <fileset dir="${pom.build.sourceDirectory}"
<                                
includes="${context.getVariable(fileset_index_includes_var_name)}"
<                              
excludes="${context.getVariable(fileset_index_excludes_var_name)}"
<                     >
---
>                     <fileset dir="${pom.build.sourceDirectory}">













---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/xdoclet/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
xdoclet-devel mailing list
xdoclet-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to