Hi Diogo, Then I understood it correctly :-) My suggestion to return a boolean from preGenerate could help for supporting the destination-dirty check, especially for plugins creating 1 artifact (xml or the likes) for the entire application.
Currently, in the patch, I overwrite the start method but it might be cleaner to handle this differently. Regards, Ive At 11:43 9/06/2006, you wrote: >I meant > >preGenerate(metadata); >templateEngine.generate(out.getWriter(), m, getEncoding(), getClass()); >posGenerate(metadata); > >I could be usefull for verbose display for example, although I don't like it >100%. > >diogo > > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf > > Of Ive Hellemans > > Sent: quinta-feira, 8 de Junho de 2006 19:58 > > To: xdoclet-plugins-interest@lists.sourceforge.net > > Subject: [xdoclet-plugins-interest]plugin-ejb-destinationdirty-and- > > verbose.patch > > > > > > I'm not 100% sure I understand what you mean, but I started following > > this list 1 week and a half ago so that might explain :-) > > > > If the pre-generate method is changed, it might be a good idea to > > return a 'continue' boolean, so the code in Plugin.java could become > > > > if (preGenerate(metadata)) { > > templateEngine.generate(out.getWriter(), m, getEncoding(), > > getClass()); > > ... > > } > > > > Anyway, until somone implements the "perfect" solution I'll work with > > the implemented one as it seems to work fine for me :-) > > > > Regards, > > Ive > > > > At 19:31 8/06/2006, you wrote: > > >Yesterday i took a look into the patch. > > > > > >It's just calling for a change in generama. Remember the preGenerate that > > I > > >made a while ago because of velocity imports... > > > > > >If we change preGenerate() to preGenerate(Object metadata) and add > > >posGenerate(Object metadata) it will fit a little better. > > > > > >Regards > > >Diogo > > > > > > > > _______________________________________________ > > xdoclet-plugins-interest mailing list > > xdoclet-plugins-interest@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/xdoclet-plugins-interest > > > >_______________________________________________ >xdoclet-plugins-interest mailing list >xdoclet-plugins-interest@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/xdoclet-plugins-interest Ive Hellemans - [EMAIL PROTECTED] _______________________________________________ xdoclet-plugins-interest mailing list xdoclet-plugins-interest@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xdoclet-plugins-interest
