On Tuesday, November 25, 2003, at 02:02 PM, Mark Lybarger wrote:
Great. I also added support for java.util.Date since that seemed to be out, via:

    static {
        supportedTypes.add("java.lang.String");
        supportedTypes.add("java.lang.Integer");
        supportedTypes.add("int");
        supportedTypes.add("java.lang.Float");
        supportedTypes.add("float");
        supportedTypes.add("java.lang.Long");
        supportedTypes.add("long");
        supportedTypes.add("java.lang.Double");
        supportedTypes.add("double");
        supportedTypes.add("java.lang.Boolean");
        supportedTypes.add("boolean");
        supportedTypes.add("java.util.Date");
        supportedTypes.add("date");
    }

None of the existing test cases broke, so I assume it all still works ok ;)

I don't believe there are any test cases for this code. But, I spot something wrong already. "date" is not a type. All the others in that list are primitives or wrapper classes (or java.lang.String). So, "date" should be removed.


If you're using Validator in a non-Struts environment, does this list of supported types even make sense anyway?

Erik



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
xdoclet-user mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-user

Reply via email to