A comment in the file reflects this finding.

Signed-off-by: Matthias Goergens <[email protected]>


 camldm/camldm_stubs.c |  10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)


# HG changeset patch
# User Matthias Goergens <[email protected]>
# Date 1274191678 -3600
# Node ID efffbb0ad177e6752dda9031d81b8258d36b3c5a
# Parent  436896a3e86eda510584d73d085ae27f2650d556
camldm/camldm_stubs.c: Tests have confirmed that camldm_ls does not leak memory.

A comment in the file reflects this finding.

Signed-off-by: Matthias Goergens <[email protected]>

diff --git a/camldm/camldm_stubs.c b/camldm/camldm_stubs.c
--- a/camldm/camldm_stubs.c
+++ b/camldm/camldm_stubs.c
@@ -238,9 +238,13 @@ void camldm_mknod(value path, value mode
   CAMLreturn0;
 }
 
-// may leak memory.  who knows?  (Does the c function I copied this
-// from (dmsetup.c) care about memory?  dmsetup exits shortly after executing
-// it.
+/*
+  May leak memory.  who knows?  (Does the c function (_process_all)
+  where I copied this from (dmsetup.c) care about memory?  dmsetup
+  exits shortly after executing it.  After testing: It does not seem
+  to leak.  Probably "dm_task_destroy(dmt);" is doing some cleaning
+  up.
+*/
 #define none Val_int(0)
 #define Tag_some Val_int(0)
 value camldm_ls()
_______________________________________________
xen-api mailing list
[email protected]
http://lists.xensource.com/mailman/listinfo/xen-api

Reply via email to