The usage of `rm` here is wrong for two reasons:
- It will fail if $sharedpath.tmp doesn't exist and report and error
(ie: -f should be used).
- It's not needed because dd will truncate $sharedpath.tmp.
Signed-off-by: Roger Pau Monné <roger....@citrix.com>
---
Cc: Ian Jackson <ian.jack...@eu.citrix.com>
---
ts-freebsd-host-install | 1 -
1 file changed, 1 deletion(-)
diff --git a/ts-freebsd-host-install b/ts-freebsd-host-install
index 447a5076..4aff7214 100755
--- a/ts-freebsd-host-install
+++ b/ts-freebsd-host-install
@@ -96,7 +96,6 @@ targetpath=$4
cd $basedir
mkdir -p `dirname $sharedpath`
if [ ! -f $sharedpath ]; then
- rm $sharedpath.tmp
dd if=$imagepath of=$sharedpath.tmp
mv $sharedpath.tmp $sharedpath
fi
--
2.13.6 (Apple Git-96)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
