On 2025-02-19 11:44, Andrew Cooper wrote:
On 19/02/2025 10:00 am, Jan Beulich wrote:
struct mctelem_ent is opaque outside of mcetelem.c; the cookie
abstraction exists - afaict - just to achieve this opaqueness. Then it
is irrelevant though which kind of pointer mctelem_cookie_t resolves
to.
IOW we can as well use struct mctelem_ent there, allowing to remove
the
casts from COOKIE2MCTE() and MCTE2COOKIE(). Their removal addresses
Misra C:2012 rule 11.2 ("Conversions shall not be performed between a
pointer to an incomplete type and any other type") violations.
No functional change intended.
Signed-off-by: Jan Beulich <jbeul...@suse.com>
https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/9181587757
Eclair does appear to be happy with this approach (assuming I stripped
down to only checking R11.2 correctly, and making it fatal).
The analysis settings are correct.
For the change itself, it's an almost identical binary, differing only
in the string section which I expect means some embedded line numbers.
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
