On 13/03/2025 1:33 pm, Jan Beulich wrote: > This was the original attempt to address XSA-467, until it was found > that IRQs can be off already from higher up the call stack. Nevertheless > moving code out of locked regions is generally desirable anyway; some of > the callers, after all, don't disable interrupts or acquire other locks. > > Hence, despite this not addressing the original report: > > Data collection solely depends on the passed in PCI device. Furthermore, > since the function only writes to a local variable, we can pull the > invocation of set_msi_source_id() (and also set_hpet_source_id()) ahead > of the acquiring of the (IRQ-safe) lock. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> It's worth noting that this patch was shown to fix the original crash, only to expose the second. i.e. it's had some testing.
