Hi, On Tue, Mar 11, 2025 at 10:28 PM Julien Grall <jul...@xen.org> wrote: > > Hi, > > On 05/03/2025 09:11, Mykola Kvach wrote: > > From: Mykyta Poturai <mykyta_potu...@epam.com> > > > > These functions may be unimplemented, so check that they exist before > > calling to prevent crashes. > > Looking at the cover letter, I see you wrote the following: > > "Add suspend/resume handlers to IOMMU drivers (there aren’t any > problems with the current implementation because the domains used for > test are thin, and this patch series implements only the very basic > logic)" > > which I read as this patch is a temporary hack until we implement IOMMU. > Is that correct? If so, can you tag it as HACK and move to the end to > end up to merge it?
Yes, you're right—if we have handlers for suspend/resume in the IOMMU driver, we don't need this patch at all. However, if we drop the iommu_suspend/resume calls from the system suspend, this commit becomes unnecessary, even within this patch series. > > Cheers, > > -- > Julien Grall > Best regards, Mykola
