Re: [PATCH] PCI/MSI: Handle the NOMASK flag correctly for all PCI/MSI backends

[Jürgen Groß]

On 26.03.25 13:05, Thomas Gleixner wrote:

The conversion of the XEN specific global variable pci_msi_ignore_mask to a
MSI domain flag, missed the facts that:

     1) Legacy architectures do not provide a interrupt domain
     2) Parent MSI domains do not necessarily have a domain info attached


Cure this by using the existing pci_msi_domain_supports() helper, which
handles all possible cases correctly.

Fixes: c3164d2e0d18 ("PCI/MSI: Convert pci_msi_ignore_mask to per MSI domain 
flag")
Reported-by: Daniel Gomez <da.go...@kernel.org>
Reported-by: Borislav Petkov <b...@alien8.de>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
Tested-by: Borislav Petkov <b...@alien8.de>
Tested-by: Daniel Gomez <da.go...@kernel.org>

Both cases result in an unconditional NULL pointer dereference.

As the patch introducing the problem went in via the Xen tree, should
this fix go in via the Xen tree, too?


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature