On 25.03.25 10:17, Juergen Gross wrote:
On 14.03.25 13:18, Juergen Gross wrote:In order to close a race window for Xenstore live update when using the new unique_id of domains, the migration stream needs to contain this unique_id for each domain known by Xenstore.Signed-off-by: Juergen Gross <jgr...@suse.com>This patch is still missing an Ack.
PING?
Julien? Juergen--- V8: - new patch V9: - instead of using an offset, use a flag for unique_id presence (Julien Grall) --- docs/designs/xenstore-migration.md | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore- migration.mdindex 082314bf72..a0acd76ce1 100644 --- a/docs/designs/xenstore-migration.md +++ b/docs/designs/xenstore-migration.md @@ -156,7 +156,7 @@ the domain being migrated. ``` 0 1 2 3 4 5 6 7 octet +-------+-------+-------+-------+-------+-------+-------+-------+ -| conn-id | conn-type | | +| conn-id | conn-type | fields | +-------------------------------+---------------+---------------+ | conn-spec ... @@ -165,6 +165,9 @@ the domain being migrated. +---------------+---------------+-------------------------------+ | data ... ++---------------------------------------------------------------+ +| unique-id | ++---------------------------------------------------------------+ ``` @@ -178,6 +181,16 @@ the domain being migrated. | | 0x0001: socket | | | 0x0002 - 0xFFFF: reserved for future use | | | | +| `fields` | A collection of flags indicating presence | +| | of additional fields after the variable | +| | length `data` part. The additional fields | +| | will start after a possible padding for | +| | aligning to a 8 octet boundary. | +| | Defined flag values (to be or-ed): | +| | 0x0001: `unique_id` present (only needed for | +| | `shared ring` connection in live | +| | update streams). | +| | | | `conn-spec` | See below | | | | | `in-data-len` | The length (in octets) of any data read | @@ -193,6 +206,9 @@ the domain being migrated. | `data` | Pending data: first in-data-len octets of | | | read data, then out-data-len octets of | | | written data (any of both may be empty) | +| | | +| `unique-id` | Unique identifier of a domain | +| | | In case of live update the connection record for the connection via which the live update command was issued will contain the response for the live
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
