On 03.04.2025 22:10, Andrew Cooper wrote:
> On 03/04/2025 7:23 pm, dm...@proton.me wrote:
>> --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
>> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
>> @@ -294,54 +294,57 @@ extern uint8_t posted_intr_vector;
>>
>> static always_inline void __vmptrld(u64 addr)
>> {
>> - asm volatile ( "vmptrld %0\n"
>> - /* CF==1 or ZF==1 --> BUG() */
>> - UNLIKELY_START(be, vmptrld)
>> - _ASM_BUGFRAME_TEXT(0)
>> - UNLIKELY_END_SECTION
>> - :
>> - : "m" (addr),
>> - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0)
>> - : "memory" );
>> + asm goto ( "vmptrld %[addr]\n"
>> + "jbe %l[vmfail]\n\t"
>
> Also cosmetic, but the very final line in the asm block ideally doesn't
> want the \n\t.
And to clarify (Andrew gave a similar comment elsewhere) the \t instead
wants to appear on the first of these two lines.
Jan
