Hi,
On 06/12/2024 19:47, Julien Grall wrote:
Hi Andrew,
Reviving this thread as we are preparing for Xen 4.20.
On 16/07/2024 07:57, Jan Beulich wrote:
On 15.07.2024 18:58, Julien Grall wrote:
On 15/07/2024 17:46, Andrew Cooper wrote:
Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
With one remark below:
Reviewed-by: Julien Grall <jgr...@amazon.com>
---
CC: Jan Beulich <jbeul...@suse.com>
CC: Stefano Stabellini <sstabell...@kernel.org>
CC: Julien Grall <jul...@xen.org>
CC: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
This is about figuring out when a change was first introduced. Take
10b719dc88 for example (completely random pick).
The right answer is `git tag --contains $sha` and look for the oldest
RELEASE-$X. In this case it's Xen 4.6, but the tags are not
numerically
sorted so the answer is towards the end of the list of 166 tags.
The better answer would be to `git describe $sha` because git has an
algorithm
to do this nicely. In this case, it's 4.5.0-rc4-934-g10b719dc8830
because we
branch first and tag RELEASE-4.6.0 on the branch, rather than
releasing off
master.
With 0082626f35af (opening of the 4.6 tree) containing an annotated
tag of
4.6-dev, git describe now gives 4.6-dev-902-g10b719dc8830 which far
more
helpful when doing code archeology.
I think some of this explanation should be in the commit message.
Imo it could even be moved up verbatim.
Would you be fine if I move your explanation in the commit message and
commit it?
Ping?
Cheers,
--
Julien Grall
