Hi Ayan,

> On 7 Apr 2025, at 19:44, Ayan Kumar Halder <ayan.kumar.hal...@amd.com> wrote:
> 
> Added a new file common.inc to hold the common earlyboot MPU regions
> configurations across arm64 and arm32.
> 
> prepare_xen_region, fail_insufficient_regions() will be used by both arm32 and
> arm64. Thus, they have been moved to common.inc.
> 
> *_PRBAR are moved to arm64/sysregs.h.
> *_PRLAR are moved to common.inc as they are common between arm32 and arm64.
> 
> Introduce WRITE_SYSREG_ASM to write to the system registers from the common 
> asm
> file.
> 
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.hal...@amd.com>
> —
> 

Provided that you fix Michal’s comment about file name (even if 
{mpu-}common.inc is more flexible and
would not need any renaming in case additional code is added that doesn’t 
involve region manipulation,
but at this stage I can’t foresee any) and protect the asm macro:

Reviewed-by: Luca Fancellu <luca.fance...@arm.com>

Please keep it if you change the code for the above comment.

Cheers,
Luca



Reply via email to