On 09.04.2025 03:44, Denis Mukhin wrote: > On Tuesday, April 8th, 2025 at 7:26 AM, Jan Beulich <jbeul...@suse.com> wrote: >> On 01.04.2025 01:05, dm...@proton.me wrote: >> >>> From: Denis Mukhin dmuk...@ford.com >>> >>> Move domain ID allocation during domain creation to a dedicated >>> function domid_alloc(). >>> >>> Allocation algorithm: >>> - If an explicit domain ID is provided, verify its availability and >>> use it if ID is unused; >>> - Otherwise, perform an exhaustive search for the first available ID >>> within the [0..DOMID_FIRST_RESERVED) range, excluding hardware_domid. >>> >>> This minimizes the use of max_init_domid in the code and, thus, is a >>> prerequisite change for enabling console input rotation across domains >>> with console input permission on x86 platforms (which currently is >>> limited to dom0, PV shim and Xen). >> >> >> By removing the updating of max_init_domid you do - afaict - break the >> remaining use site(s) of the variable. > > Unfortunately, this patch should go together with the next patch in > this series: > xen/domain: introduce domid_top() > > I mentioned dependency in the cover letter.
No, that would still break bisectability. Also such dependencies would better be mentioned in both the cover letter and the patch(es). Going back to the cover letter, all I find is "Patch 3 depends on patch 2." That's the natural thing in a series. Jan