On 16.04.2025 10:29, Andrew Cooper wrote: > On 15/04/2025 4:32 pm, Roger Pau Monne wrote: >> diff --git a/xen/include/xen/io.h b/xen/include/xen/io.h >> new file mode 100644 >> index 000000000000..4495a04c403e >> --- /dev/null >> +++ b/xen/include/xen/io.h >> @@ -0,0 +1,68 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * IO related routines. >> + * >> + * Copyright (c) 2025 Cloud Software Group >> + */ >> +#ifndef XEN_IO_H >> +#define XEN_IO_H >> + >> +#include <xen/bug.h> >> + >> +#include <asm/io.h> >> + >> +static inline unsigned long read_mmio(const volatile void __iomem *mem, > > void *__iomem. (i.e. without the __iomem in the middle of the type). > It seems most examples of this in Xen are wrong.
Hmm, perhaps in turn because I don't see why it would need to be that placement. The attribute describes what's pointed to, not the variable (or parameter here) itself. Jan
