On 17.04.2025 12:10, Oleksii Kurochko wrote: > On 4/15/25 5:55 PM, Jan Beulich wrote >>> + /* >>> + * we don't care for now which CPU will receive the >>> + * interrupt >>> + * >>> + * TODO: Handle case where IRQ is setup on different CPU than >>> + * the targeted CPU and the priority. >>> + */ >>> + irq_set_affinity(desc, cpumask_of(smp_processor_id())); >>> + desc->handler->startup(desc); >>> + /* enable irq */ >>> + clear_bit(_IRQ_DISABLED, &desc->status); >> Now it turns out this is really done twice: Once in aplic_irq_enable(), >> and once here. > > Agree, this is a job of *_startup()->*_aplic_irq_enable(). I'll drop that too.
Wait - see my comment there. I think it belongs here, not there. Jan