On 17.04.2025 14:48, Alejandro Vallejo wrote: > From: "Daniel P. Smith" <dpsm...@apertussolutions.com> > > Add a container for the "cooked" command line for a domain. This > provides for the backing memory to be directly associated with the > domain being constructed. This is done in anticipation that the domain > construction path may need to be invoked multiple times, thus ensuring > each instance had a distinct memory allocation. > > Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com> > Signed-off-by: Jason Andryuk <jason.andr...@amd.com> > Signed-off-by: Alejandro Vallejo <agarc...@amd.com>
Acked-by: Jan Beulich <jbeul...@suse.com> preferably with ... > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -653,7 +653,7 @@ static int __init pvh_load_kernel( > void *image_start = image_base + image->headroom; > unsigned long image_len = image->size; > unsigned long initrd_len = initrd ? initrd->size : 0; > - const char *cmdline = image->cmdline_pa ? __va(image->cmdline_pa) : NULL; > + unsigned long cmdline_len = bd->cmdline ? strlen(bd->cmdline) + 1 : 0; ... this becoming either size_t (as you have it elsewhere) or unsigned int. Happy to make the adjustment while committing, so long as you agree with either of the suggested variants. Jan
