Re: [PATCH v2 1/8] xen/arm: drop declaration of handle_device_interrupts()

[Orzel, Michal]

On 22/04/2025 16:31, Oleksii Kurochko wrote:
> 
> On 4/17/25 9:38 AM, Orzel, Michal wrote:
>> On 14/04/2025 17:56, Oleksii Kurochko wrote:
>>> There is no any users of handle_device_interrupts() thereby it
>>> could be dropped.
>> It reads as if you were dropping a definition. There is no definition, 
>> therefore
>> no users. Prototype was added by accident in:
>> 8d2c3ab18cc1fce46945bd3aa1819a7aea0c564e
> 
> I will reword it to:
>  There is no definition of handle_device_interrupts() thereby it could be 
> dropped.
> 
> Should I add Fixes tag to mention that it was added by accident in 
> 8d2c3ab18cc1fce46945bd3aa1819a7aea0c564e? Or it will be enough just to 
> mention that
> in the commit message?
No need for Fixes tag.

~Michal

> 
>>> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
>> With the commit msg updated to be more meaningful:
>> Reviewed-by: Michal Orzel <michal.or...@amd.com>
> 
> Thanks.
> 
> ~ Oleksii
>