On 23.04.2025 00:11, dm...@proton.me wrote: > On Tue, Apr 22, 2025 at 09:56:00AM +0200, Jan Beulich wrote: >> On 22.04.2025 03:15, dm...@proton.me wrote: >>> From: Denis Mukhin <dmuk...@ford.com> >>> >>> Current implementation of __vmread() returns the result via pointer argument >>> which leads to having excess code in some places. >>> >>> Update the signature of __vmread() to return `unsigned long` and drop the >>> pointer argument as per suggestion in [1]. >>> >>> Update all call sites everywhere in the VT-x code. >> >> You did read Andrew's reply to v1 before posting v2, didn't you? > > I missed to address the function name change request, posted v3: > https://lore.kernel.org/xen-devel/20250422215833.522007-1-dmuk...@ford.com/
That was only part of what was asked for. Andrew also gave a pretty clear outline of how to avoid the need to touch all use sites in one single patch. Plus he explained why it's better to do this in smaller steps. Jan
