On April 24, 2025 10:49:59 AM PDT, Xin Li <x...@zytor.com> wrote: >On 4/24/2025 3:05 AM, Jürgen Groß wrote: >> >> May I suggest to get rid of the "emul" parameter of pmu_msr_chk_emulated()? >> It has no real value, as pmu_msr_chk_emulated() could easily return false in >> the cases where it would set *emul to false. > >Good idea! > >The function type is a bit of weird but I didn't think of change it.
It is weird in the extreme. By the way, this patch should have "xen" in its subject tag.