On 25/04/2025 12:37 pm, Oleksii Kurochko wrote: > > > On 4/25/25 1:24 PM, Andrew Cooper wrote: >> From: Shawn Anastasio <sanasta...@raptorengineering.com> >> >> Signed-off-by: Shawn Anastasio <sanasta...@raptorengineering.com> >> --- >> CC: Jan Beulich <jbeul...@suse.com> >> CC: Roger Pau Monné <roger....@citrix.com> >> CC: Stefano Stabellini <sstabell...@kernel.org> >> CC: Julien Grall <jul...@xen.org> >> CC: Volodymyr Babchuk <volodymyr_babc...@epam.com> >> CC: Bertrand Marquis <bertrand.marq...@arm.com> >> CC: Michal Orzel <michal.or...@amd.com> >> CC: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >> CC: Shawn Anastasio <sanasta...@raptorengineering.com> >> >> Possibly not for taking on it's own (might be better with the PPC >> implemenation of map_pages_to_xen()). >> >> Nevertheless, this patch alone now does trip: >> >> diff --git a/xen/common/vmap.c b/xen/common/vmap.c >> index d6991421f3f7..9552806dba39 100644 >> --- a/xen/common/vmap.c >> +++ b/xen/common/vmap.c >> @@ -228,6 +228,8 @@ void *__vmap(const mfn_t *mfn, unsigned int >> granularity, >> void *va = vm_alloc(nr * granularity, align, type); >> unsigned long cur = (unsigned long)va; >> >> + BUILD_BUG_ON(sizeof(pte_attr_t) != 4); >> + > Could you please clarify what kind of changes should done in the case if > sizeof(pte_attr_t) == 8 (unsigned long)?
Nothing. This is simply to demonstrate that __has_include() is working, and is making PPC different to all the other architectures. ~Andrew.
