On 24.04.25 16:43, Anthony PERARD wrote:
On Tue, Apr 08, 2025 at 02:35:22PM +0200, Juergen Gross wrote:diff --git a/INSTALL b/INSTALL index 88c1464816..786e3da996 100644 --- a/INSTALL +++ b/INSTALLThere's one "--enable-ioemu-stubdom" left in this file.
Oh, thanks for noticing.
diff --git a/stubdom/Makefile b/stubdom/Makefile index 724ce40365..82fc1e90f8 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -544,13 +478,6 @@ else install: $(STUBDOMPATH) endif-install-ioemu: ioemu-stubdom- $(INSTALL_DIR) "$(DESTDIR)$(LIBEXEC_BIN)" - $(INSTALL_PROG) stubdom-dm "$(DESTDIR)$(LIBEXEC_BIN)" - $(INSTALL_DATA) stubdompath.sh "$(DESTDIR)$(LIBEXEC_BIN)"If we don't install "stubdompath.sh", we don't need to make it anymore, that is $(STUBDOMPATH) rule and as prerequisite isn't needed anymore. I think "stubdompath.sh" is only used by "stubdom-dm", so we can remove all mention of "stubdompath.sh" or "$(STUBDOMPATH)", here or in the next patch. And with $(STUBDOMPATH) path gone, this will be the user of the make macro $(buildmakevars2file) and $(BUILD_MAKE_VARS), so I think the could be both removed as well.
Will do so.
- $(INSTALL_DIR) "$(DESTDIR)$(XENFIRMWAREDIR)" - $(INSTALL_DATA) mini-os-$(XEN_TARGET_ARCH)-ioemu/mini-os.gz "$(DESTDIR)$(XENFIRMWAREDIR)/ioemu-stubdom.gz" - install-grub: pv-grub $(INSTALL_DIR) "$(DESTDIR)$(XENFIRMWAREDIR)" $(INSTALL_DATA) mini-os-$(XEN_TARGET_ARCH)-grub/mini-os.gz "$(DESTDIR)$(XENFIRMWAREDIR)/pv-grub-$(XEN_TARGET_ARCH).gz" diff --git a/tools/Makefile b/tools/Makefile index e9e1cda305..6ecf7c0da8 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -136,54 +129,6 @@ endif - -qemu-traditional-recurse = \ - set -e; \ - $(buildmakevars2shellvars); \These are the last mention of the make macro $(buildmakevars2shellvars), so we can remove it from Config.mk.
Agreed. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
