On 29.04.2025 13:06, Juergen Gross wrote: > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmware/hvmloader/Makefile > @@ -59,6 +59,7 @@ OBJS += optionroms.o 32bitbios_support.o rombios.o > CFLAGS += -DENABLE_ROMBIOS > ROMBIOS_ROM := $(ROMBIOS_DIR)/BIOS-bochs-latest > ROMS += $(ROMBIOS_ROM) $(STDVGA_ROM) $(CIRRUSVGA_ROM) > +DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c > endif
To be resilient to a random DSDT_FILES in the environment, I think you want to use += here as well, just like ... > @@ -76,7 +77,7 @@ rombios.o: roms.inc > smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\"" > > ACPI_PATH = ../../libacpi > -DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c > +DSDT_FILES += dsdt_anycpu_qemu_xen.c ... you have it here, and set the variable to nothing yet further up. Then Acked-by: Jan Beulich <jbeul...@suse.com> # hvmloader Jan
