On 30/04/2025 2:13 pm, Jan Beulich wrote: > In a number of cases we use ALTERNATIVE_2 with both replacement insns / > insn sequences being identical. Avoid emitting the same code twice, and > instead alias the necessary helper labels to the existing ones. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
On a random build, the size of .altinstr_replacement drops from 0xe47 to 0xdf8, so not too bad. While the patch is fine, if we're adjusting the assembly ALTERNATIVE_2, we should make the same adjustment to the C version, even if there's nothing to benefit from it immediately. ~Andrew P.S. it would be even nicer if we would put these in mergeable sections, but I haven't figured out way to set the mergable unit size, which needs to be an absolute expression.