On Wed, May 07, 2025 at 06:38:45AM +0000, Chen, Jiqian wrote: > On 2025/5/7 00:00, Roger Pau Monné wrote: > > On Mon, Apr 21, 2025 at 02:18:58PM +0800, Jiqian Chen wrote: > >> + } > >> + > >> + /* PCI_CAP_LIST_NEXT register of target capability */ > >> + list_del(&next_r->node); > >> + spin_unlock(&vpci->lock); > >> + xfree(next_r); > > > > Here vpci_remove_register() could also be used, but it will involve > > searching again for the register to remove, which is a bit pointless. > Yes, so just keeping things here instead of calling vpci_remove_register()?
I would add a small comment that we avoid calling vpci_remove_register() to not have to redo the register search. Thanks, Roger.
