On Mon, May 19, 2025 at 07:35:49AM +0000, Chen, Jiqian wrote: > On 2025/5/18 22:44, Jan Beulich wrote: > > On 09.05.2025 11:05, Jiqian Chen wrote: > >> +static int vpci_capability_mask(struct pci_dev *pdev, unsigned int cap) > > > > What's the word "mask" indicating here? The function doesn't return any > > mask afaics. Do you perhaps mean "hide"? > Yes, hide. > This is a question of naming preference. > I remember Roger suggested this name, but maybe I remember wrong. > For double confirmation, hi Roger, are you fine that I change this name from > mask to hide?
Sure, it's fine to use hide, and it's possibly more inline with how we use hide in other functions (like pci_hide_device()). Thanks, Roger.
