Hi Mykyta, I have only skimmed through the patch. But there is something that caught my eye in both this patch and the one for the SMMUv2.
On 28/05/2025 10:12, Mykyta Poturai wrote:
+ /* dom_io is used as a sentinel for quarantined devices */ + if ( d == dom_io ) + { + struct arm_smmu_master *master = dev_iommu_priv_get(dev); + if ( !iommu_quarantine ) + return 0; + + if ( master && master->domain ) + arm_smmu_deassign_dev(master->domain->d, devfn, dev);
arm_smmu_deassign_dev() can return an error. Can you explain why this is fine to ignore it?
+ + return 0; + } + } +#endif +
Cheers, -- Julien Grall