It being non-static and it not having a declaration (anymore) violates one or more Misra rules, iirc.
Fixes: ff3e5dfa7c2d ("x86/mm: move mmio_ro_emulated_write() to PV only file") Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -337,7 +337,7 @@ static int cf_check mmcfg_intercept_writ return X86EMUL_OKAY; } -int cf_check mmio_ro_emulated_write( +static int cf_check mmio_ro_emulated_write( enum x86_segment seg, unsigned long offset, void *p_data,