On Mon Jun 2, 2025 at 9:55 AM CEST, Jan Beulich wrote: > On 30.05.2025 14:02, Alejandro Vallejo wrote: >> A later patch removes boot_module and replaces its uses with bootmodule. >> The equivalent field for "type" doesn't have BOOTMOD_UNKNOWN as a zero >> value, so it must be explicitly set in the static xen_boot_info. >> >> Not a functional change. >> >> Signed-off-by: Alejandro Vallejo <agarc...@amd.com> >> --- >> xen/arch/x86/setup.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >> index 1f5cb67bd0..5da9df33c9 100644 >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -298,6 +298,7 @@ struct boot_info __initdata xen_boot_info = { >> .loader = "unknown", >> .cmdline = "", >> .domains = { [0 ... MAX_NR_BOOTDOMS - 1] = { .domid = DOMID_INVALID } }, >> + .mods = { [0 ... MAX_NR_BOOTMODS] = { .type = BOOTMOD_UNKNOWN } }, >> }; > > A brief comment may be nice, to help readers understand that there is no off- > by-1 here. > > Jan
Sure. Cheers, Alejandro