On 05.06.2025 21:47, Alejandro Vallejo wrote:
> --- a/xen/include/asm-generic/device.h
> +++ b/xen/include/asm-generic/device.h
> @@ -1,14 +1,20 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * This header helps DTB-based architectures abstract away where a particular
> + * device came from, be it the DTB itself or enumerated on a PCI bus.
> + */
> #ifndef __ASM_GENERIC_DEVICE_H__
> #define __ASM_GENERIC_DEVICE_H__
>
> +#ifndef CONFIG_HAS_DEVICE_TREE
> +#error "Header for exclusive use of DTB-based architectures"
> +#endif
> +
> #include <xen/stdbool.h>
>
> enum device_type
> {
> -#ifdef CONFIG_HAS_DEVICE_TREE
> DEV_DT,
> -#endif
> DEV_PCI
> };
My objection to these changes remains; as a generic header it ought to be what
that attribute says - generic.
Jan
