On 10.06.2025 19:46, Stewart Hildebrand wrote: > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -258,6 +258,16 @@ config PARTIAL_EMULATION > > source "arch/arm/firmware/Kconfig" > > +config PCI_PASSTHROUGH > + bool "PCI passthrough" if EXPERT > + depends on ARM_64 > + select HAS_PCI > + select HAS_VPCI > + select HAS_VPCI_GUEST_SUPPORT
What about HAS_PASSTHROUGH? Seeing that being selected by MMU, what about that connection here? Selecting HAS_VPCI shouldn't really be necessary; HAS_VPCI_GUEST_SUPPORT does that for you already. (I further wonder whether HAS_VPCI wouldn't in turn better select HAS_PCI.) > + default n This is unnecessary (redundant) and would hence better be omitted. Jan
