On 27.05.2025 10:48, Penny Zheng wrote:
> AMD cpufreq cores will be intialized in two modes, legacy P-state mode,
> and CPPC mode. So "init" flag shall be extracted from px-specific
> "struct xen_processor_perf", and placed in the common
> "struct processor_pminfo". Otherwise, later when introducing a new
> sub-hypercall to propagate CPPC data, we need to pass irrelevant px-specific
> "struct xen_processor_perf" to just set init flag.
>
> Signed-off-by: Penny Zheng <penny.zh...@amd.com>
Acked-by: Jan Beulich <jbeul...@suse.com>
I'd be happy to put this in right away, but aiui ...
> @@ -228,7 +228,7 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)
> ret = copy_to_guest(op->u.get_para.affected_cpus,
> data, op->u.get_para.cpu_num);
>
> - if ( pmpt->perf.init & XEN_PX_INIT )
> + if ( pmpt->init & XEN_PX_INIT )
> {
> for ( i = 0; i < op->u.get_para.freq_num; i++ )
> data[i] = pmpt->perf.states[i].core_frequency * 1000;
... this hunk needs dropping then, as the modified code is only introduced
by patch 1. Which raises the question why you didn't order the patches the
other way around, avoiding to immediately need to touch the same (new) code
again. Please clarify.
Jan
