On 11/06/2025 20:46, Luca Fancellu wrote:
Hi Ayan,
Hi Luca,
On 11 Jun 2025, at 15:35, Ayan Kumar Halder <ayan.kumar.hal...@amd.com> wrote: Create xen/arch/arm/mpu/arm32 to hold arm32 specific bits. Signed-off-by: Ayan Kumar Halder <ayan.kumar.hal...@amd.com> --- Changes from :- v1..v2 - New patch in v3. xen/arch/arm/mpu/Makefile | 2 +- xen/arch/arm/mpu/arm32/Makefile | 1 + xen/arch/arm/mpu/{ => arm32}/domain-page.c | 0 3 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 xen/arch/arm/mpu/arm32/Makefile rename xen/arch/arm/mpu/{ => arm32}/domain-page.c (100%)Uhm, why? Arm64 is using domain-page.c: https://gitlab.com/xen-project/people/lucafancellu/xen/-/commit/b28198d00078991d4a6502e94c8779d84fec0120 Did I miss something?
Oh, I did not look at the future patches. I can drop this patch in my next series once you and Michal/Julien reviews the other patches.
I feel it is cleaner to have separate implementations for prepare_selector(), read_protection_region(), write_protection_region() between arm32 and arm64. (Refer patch 4 and 6)
Let me know how it looks like. - Ayan
Cheers, Luca
