On 27.05.2025 10:48, Penny Zheng wrote: > We want to bypass construction of px statistic info, while not bypassing > cpufreq_statistic_lock initialization for a good reason, in > cpufreq_statistic_init() for amd-cppc mode, as P-states is not necessary > there. > > Signed-off-by: Penny Zheng <penny.zh...@amd.com> > Acked-by: Jan Beulich <jbeul...@suse.com>
I was considering to put this in together with patch 02 (if and when you confirmed that it can go in with the one hunk dropped), but then noticed that ... > --- a/xen/drivers/cpufreq/utility.c > +++ b/xen/drivers/cpufreq/utility.c > @@ -98,6 +98,9 @@ int cpufreq_statistic_init(unsigned int cpu) > if ( !pmpt ) > return -EINVAL; > > + if ( !(pmpt->init & XEN_PX_INIT) ) > + return 0; ... this check is pointless with how things are right now (the same check living at the top of the sole caller). Hence I think this change should be folded into patch 04. Perhaps to be accompanied by a sentence why cpufreq_statistic_exit() doesn't need a similar guard. Jan
