On 27.05.2025 10:48, Penny Zheng wrote: > Unlike Cx/Px states, for which we need an extra loop to summerize residency ( > sum_cx[]/sum_px[]), we could call get_avgfreq_by_cpuid() right before > printing. > Also, with introduction of CPPC mode, average frequency print shall > not depend on the existence of legacy P-states, so we remove "px_cap" > dependancy check. > > Fixes: add6160d7 (Add cpufreq actual average freq information to xenpm tools)
Unlike in earlier instances, here you have a fixes tag when the title merely says "optimize". I also can't spot any bug that would be fixed here; what you address is indeed an inefficiency. As and aside: The Fixes: tag wants 12 digits of the hash quoted, and the canonical form also has the title in quotes. You'll find numerous good examples in patches being submitted. Jan
